Module talk:Message box

This module was considered for deletion on 2020 February 15. The result of the discussion was "keep".

Module:Message box is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit protected}} to notify an administrator to make the requested edit.

Text and/or other creative content from this version of Module:Message_box was copied or moved into incubator:Module:Wp/nod/Message_box with this edit. The former page's history now serves to provide attribution for that content in the latter page, and it must not be deleted as long as the latter page exists.

Archives

Archive 1

This page has archives. Sections older than 30 days may be automatically archived by when more than 4 sections are present.

Edit request 23 November 2023[edit]

‹ The template below (Edit fully-protected) is being considered for merging. See templates for discussion to help reach a consensus. ›

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

On Module:Message box/configuration, after line 152, please add

		license-related = {
				class = 'imbox-license',
				image = 'Imbox-license.svg'
			},

.

Reasoning: Some templates, like {{Insignia}}, use the "license" type of imbox. But this produces a licensetpl class, which confuses whatever MediaWiki thing populates Category:Files with no machine-readable license. Adding this would allow those to be converted to an identical-looking type "license-related" without the class, depopulating much of the category.

Best, — Mdaniels5757 (talk • contribs) 20:47, 23 November 2023 (UTC)[reply]

Done * Pppery * _{it has begun...} 02:42, 24 November 2023 (UTC)[reply]

Edit request to alter removalNotice text[edit]

‹ The template below (Edit fully-protected) is being considered for merging. See templates for discussion to help reach a consensus. ›

This edit request to Module:Message box/configuration has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

The removal notice in message boxes refers to the displayed banner as a "template message". That is overly described; nobody cares how it was produced (if they did, maybe we should call it a "module message", or a "template-driven, module-implemented message"); they only care what it is you want to remove (and how). Suggested improvement:

To me, it's a "banner", not a "message", so I'd prefer the former word, but I wouldn't object to just "message" without the "template" part. Among other things, the shorter version will cause a fraction of banners to have one fewer line at certain page widths. Thanks, Mathglot (talk) 22:26, 27 April 2024 (UTC)[reply]

Done * Pppery * _{it has begun...} 03:25, 29 April 2024 (UTC)[reply]

Protected edit request on 4 May 2024[edit]

‹ The template below (Edit fully-protected) is being considered for merging. See templates for discussion to help reach a consensus. ›

This edit request to Module:Message box/ombox.css has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

This ombox defines a backgroundcolor, without defining a text color, which is problematic in the new darkmod. I suggest we add color: #202122 to the first styling block to. —TheDJ (talk • contribs) 15:58, 4 May 2024 (UTC)[reply]

Done — Martin (MSGJ · talk) 20:54, 6 May 2024 (UTC)[reply]

Ick, dark grey instead of ordinary black. I suppose that matches the same done in Vector, but it mismatches other skins. Anomie ⚔ 11:50, 7 May 2024 (UTC)[reply]

Yes, this is one reason I've been leery of fixing dark mode by adding color: definite_color... Izno (talk) 04:10, 21 May 2024 (UTC)[reply]

Edit request 8 May 2024[edit]

‹ The template below (Edit fully-protected) is being considered for merging. See templates for discussion to help reach a consensus. ›

This edit request to Module:Message box/ombox.css has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Description of suggested change: Add CSS styling for night mode to the ombox styles.css. Diff:

Andumé (talk) 23:45, 8 May 2024 (UTC)[reply]

Another option with a darker/higher contrast/more consistent color scheme would be this:

Andumé (talk) 17:37, 11 May 2024 (UTC)[reply]

Not done: These diffs introduce duplicate styles and more color styles than are necessary to deal with the issue of dark mode. Thanks for throwing something up though, I will take a look. Izno (talk) 04:06, 21 May 2024 (UTC)[reply]

@I Am Andumé For the first, you copy-pasted the full .ombox definition in the context of the color CSS, which is surely not intended. For the second, you typoed the prefers-color-scheme dark selector (it should be -os, not -night), made multiple separate blocks for the prefers-color scheme (perhaps to show that you were consistent between -dark and -os settings, IDK), and more concerningly you strayed to changing the background rather than changing just the border. We should do something which matches the earlier rules in what is being set, which for most of these cases is just the border. Izno (talk) 04:22, 21 May 2024 (UTC)[reply]

Actually taking a look what happens when the background is dark, I don't think we need to change the border colors at all and can leave those the same as the base colors. That simplifies maintenance tremendously. We need to pick a good dark color for the typical background, as well as the speedy color. Izno (talk) 04:37, 21 May 2024 (UTC)[reply]

I put those in the official sandbox and loaded that so now you can see them on Template:Ombox/testcases#name=_text=text. Izno (talk) 04:55, 21 May 2024 (UTC)[reply]

@Izno:

Thanks for taking a look at my request. Here are a few things I'd like to mention:

The reason I copy-pasted the full .ombox definition, instead of just the styling that needed to be different in night mode was because I was afraid the other CSS would not be applied to the night mode version of the template if I omitted it.
That was a typo, yes.
I made separate block for the prefers-color-scheme as I was not yet aware it was possible to combine it all into one.
Changing the background color was necessary as otherwise it would have been very bright (as you seem to have noticed). Also, without either defining color or changing background color, the text would not have been readable.

Anyways, I wrote this CSS quite a while ago, so I was very inexperienced at the time, which explains a lot of the mistakes I made. Andumé (talk) 05:07, 21 May 2024 (UTC)[reply]

No worries. Yes, it was necessary to change the background, but only for the broad .ombox and for the more narrow .ombox-speedy. You included background colors elsewhere. Which can reasonably be explained by your inexperience with CSS as you explained. Izno (talk) 05:16, 21 May 2024 (UTC)[reply]

@Izno: iirc, the addition of the other background colors was also because I first worked on the cmbox CSS, and then reused much of the styling for ombox. Andumé (talk) 05:36, 21 May 2024 (UTC)[reply]

That would explain the blue! Izno (talk) 05:54, 21 May 2024 (UTC)[reply]